Skip to content

Cherry-pick #22295 to 7.10: [Filebeat][Cisco Umbrella module] Adding missing timeout options and fixing module config.yml#22299

Merged
marc-gr merged 1 commit intoelastic:7.10from
marc-gr:backport_22295_7.10
Nov 2, 2020
Merged

Cherry-pick #22295 to 7.10: [Filebeat][Cisco Umbrella module] Adding missing timeout options and fixing module config.yml#22299
marc-gr merged 1 commit intoelastic:7.10from
marc-gr:backport_22295_7.10

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Oct 30, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22295 to 7.10 branch. Original message:

What does this PR do?

This fixes missing config items for Cisco Umbrella, might have been missing from the start or been removed during a merge.

Why is it important?

Umbrella fileset needs the config parameters to function.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@P1llus @marc-gr
adding timeout options to cisco umbrella and fixing the missing confi…
a12ccd0 
…g options in module config.yml (elastic#22295)

(cherry picked from commit b18b333)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 30, 2020

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2020
@marc-gr marc-gr requested a review from a team October 30, 2020 10:55
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 30, 2020

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4456
Skipped 567
Total 5023

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 30, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22299 opened]

  • Start Time: 2020-10-30T10:55:58.907+0000

  • Duration: 74 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 4456
Skipped 567
Total 5023

@marc-gr marc-gr merged commit f871a86 into elastic:7.10 Nov 2, 2020
@marc-gr marc-gr deleted the backport_22295_7.10 branch November 2, 2020 08:39
@zube zube bot removed the [zube]: Done label Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adriansr adriansr adriansr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marc-gr @elasticmachine @adriansr @P1llus