Skip to content

Cherry-pick #22055 to 7.x: revert WSS process reporting for windows#22063

Merged
fearful-symmetry merged 1 commit intoelastic:7.xfrom
fearful-symmetry:backport_22055_7.x
Oct 21, 2020
Merged

Cherry-pick #22055 to 7.x: revert WSS process reporting for windows#22063
fearful-symmetry merged 1 commit intoelastic:7.xfrom
fearful-symmetry:backport_22055_7.x

Conversation

@fearful-symmetry
Copy link
Copy Markdown
Contributor

@fearful-symmetry fearful-symmetry commented Oct 21, 2020

Cherry-pick of PR #22055 to 7.x branch. Original message:

What does this PR do?

This reverts the change to report system.process.memory.rss as wss on windows.

Why is it important?

@mukeshelastic and I decided that this change was unnecessary. We're reporting what is fundamentally the same metric as two different fields depending on the OS. This is particularly burdensome for users wanting to make queries against these fiends across OS. When we have the opportunity to make breaking changes, we may want to rename this to system.process.memory.pct or something similar.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Pull down PR and build on windows
  • Ensure that memory.rss is present on the system/process metricset

* revert WSS process reporting for windows

* add changelog

(cherry picked from commit ba2b2f9)
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 21, 2020
@botelastic
Copy link
Copy Markdown

botelastic bot commented Oct 21, 2020

This pull request doesn't have a Team:<team> label.

@fearful-symmetry fearful-symmetry requested a review from a team October 21, 2020 18:49
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22063 opened]

  • Start Time: 2020-10-21T18:49:26.211+0000

  • Duration: 92 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 2244
Skipped 506
Total 2750

@fearful-symmetry fearful-symmetry merged commit adb735c into elastic:7.x Oct 21, 2020
@zube zube bot removed the [zube]: Done label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants