Skip to content

Cherry-pick #21951 to 7.10: Always try snapshot repo for agent upgrade #22011

Merged
michalpristas merged 1 commit intoelastic:7.10from
michalpristas:backport_21951_7.10
Oct 21, 2020
Merged

Cherry-pick #21951 to 7.10: Always try snapshot repo for agent upgrade #22011
michalpristas merged 1 commit intoelastic:7.10from
michalpristas:backport_21951_7.10

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Oct 20, 2020

Cherry-pick of PR #21951 to 7.10 branch. Original message:

What does this PR do?

This PR adds ability of agent to download new version from snapshot repo. This makes update from stable version e.g 7.10 to 8.0.0 SNAPSHOT possible.

Why is it important?

For this to be possible user needs to initiate upgrade using API and provide sourceURI or Kibana needs to be upgraded from stable to SNAPSHOT before agent, so this is not a very common scenario but we're not blocking it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

cc @EricDavisX

@michalpristas
[Ingest Manager] Always try snapshot repo for agent upgrade (elastic#…
ff0e7c9 
…21951)

[Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951)
@michalpristas michalpristas self-assigned this Oct 20, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 20, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 20, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 20, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22011 opened]

  • Start Time: 2020-10-20T09:39:32.519+0000

  • Duration: 38 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 1394
Skipped 4
Total 1398

blakerouse
blakerouse approved these changes Oct 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michalpristas michalpristas merged commit 66172ad into elastic:7.10 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels

backport bug Ingest Management:beta2 Group issues for ingest management beta2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalpristas @elasticmachine @blakerouse