Cherry-pick #21681 to 7.x: Fix TestDockerStart flaky test#21989
Merged
jsoriano merged 1 commit intoelastic:7.xfrom Oct 19, 2020
Merged
Cherry-pick #21681 to 7.x: Fix TestDockerStart flaky test#21989jsoriano merged 1 commit intoelastic:7.xfrom
jsoriano merged 1 commit intoelastic:7.xfrom
Conversation
Some changes are done to give more resilience to the test: * Wait till image pull is finished, and retry in case of failure. * Checked events are filtered by container id instead of image name, so tests are not affected by other containers that may be running in the system. * Check timeout is for all events now, instead of being reset after an event is received. * Container is removed after test is finished. (cherry picked from commit a79dddc)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
kaiyan-sheng
approved these changes
Oct 19, 2020
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21681 to 7.x branch. Original message:
Some changes are done to give more resilience to the test:
so tests are not affected by other containers that may be running
in the system.
event is received.
Fixes #20360.