Skip to content

Cherry-pick #21896 to 7.10: Kubernetes leaderelection improvements#21954

Merged
ChrsMark merged 1 commit intoelastic:7.10from
ChrsMark:backport_21896_7.10
Oct 19, 2020
Merged

Cherry-pick #21896 to 7.10: Kubernetes leaderelection improvements#21954
ChrsMark merged 1 commit intoelastic:7.10from
ChrsMark:backport_21896_7.10

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Oct 19, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21896 to 7.10 branch. Original message:

What does this PR do?

  1. Creates leader lease under the same namespace of Beat is running (in case of inCluster mode). If not running inside k8s cluster then it defaults to default namespace.
  2. Changes ReleaseOnClose initialisation value to false so as to avoid errors like:
E1015 17:07:38.138511       1 leaderelection.go:296] Failed to release lock: Lease.coordination.k8s.io "metricbeat-cluster-leader" is invalid: spec.leaseDurationSeconds: Invalid value: 0: must be greater than 0

@ChrsMark ChrsMark added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Oct 19, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 19, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2020
@ChrsMark ChrsMark requested a review from jsoriano October 19, 2020 08:20
narph
narph approved these changes Oct 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 19, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21954 opened]

  • Start Time: 2020-10-19T08:20:56.672+0000

  • Duration: 109 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 16331
Skipped 1365
Total 17696

@ChrsMark ChrsMark merged commit 3841f41 into elastic:7.10 Oct 19, 2020
@zube zube bot removed the [zube]: Done label Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narph narph narph approved these changes

@jsoriano jsoriano Awaiting requested review from jsoriano

Assignees

No one assigned

Labels

backport Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrsMark @elasticmachine @narph