Skip to content

Cherry-pick #21930 to 7.10: [libbeat] Fix potential deadlock in the disk queue + add more unit tests#21943

Merged
faec merged 1 commit intoelastic:7.10from
faec:backport_21930_7.10
Oct 19, 2020
Merged

Cherry-pick #21930 to 7.10: [libbeat] Fix potential deadlock in the disk queue + add more unit tests#21943
faec merged 1 commit intoelastic:7.10from
faec:backport_21930_7.10

Conversation

@faec
Copy link
Copy Markdown
Contributor

@faec faec commented Oct 16, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21930 to 7.10 branch. Original message:

What does this PR do?

Fix a potential reader deadlock @fearful-symmetry found during testing, and add unit tests for all of the adjacent logic.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Oct 16, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 16, 2020

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 16, 2020
@faec faec requested a review from fearful-symmetry October 16, 2020 22:05
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 16, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21943 opened]

  • Start Time: 2020-10-16T22:06:09.701+0000

  • Duration: 102 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 16335
Skipped 1365
Total 17700

@faec faec merged commit c8d845e into elastic:7.10 Oct 19, 2020
@zube zube bot removed the [zube]: Done label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry

Assignees

No one assigned

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@faec @elasticmachine @ChrsMark