Cherry-pick #21712 to 7.x: Add tests for fileProspector in filestream input#21885
Merged
kvch merged 1 commit intoelastic:7.xfrom Oct 20, 2020
Merged
Cherry-pick #21712 to 7.x: Add tests for fileProspector in filestream input#21885kvch merged 1 commit intoelastic:7.xfrom
kvch merged 1 commit intoelastic:7.xfrom
Conversation
## What does this PR do? This PR adds tests to see how `fileProspector` handles Create, Write and Delete operations. In order to make the `Prospector` testable I changed `HarvesterGroup` an interface so it can be mocked During the testing an issue with path identifier showed up when a file was deleted. The identifier generated an incorrect value for `Name`. Now it is fixed. (cherry picked from commit 2151d15)
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
michalpristas
approved these changes
Oct 20, 2020
Contributor
michalpristas
left a comment
There was a problem hiding this comment.
Backport looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21712 to 7.x branch. Original message:
What does this PR do?
This PR adds tests to see how
fileProspectorhandles Create, Write and Delete operations. In order to make theProspectortestable I changedHarvesterGroupan interface so it can be mockedDuring the testing an issue with path identifier showed up when a file was deleted. The identifier generated an incorrect value for
Name. Now it is fixed.Why is it important?
Adds unit test of fileProspector to increase coverage.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.