Cherry-pick #21759 to 7.x: Make API address and Shard ID required in Cloud Foundry settings#21786
Merged
jsoriano merged 2 commits intoelastic:7.xfrom Oct 14, 2020
Merged
Conversation
…stic#21759) Having an auto-generated Shard ID leads to duplicated data when trying to scale, increasing the problems of loaded systems. Forcing to set a shard ID makes the user more conscious of the implications of this setting. API address should be always set in a real deployment. (cherry picked from commit 3e5a167)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
ChrsMark
approved these changes
Oct 14, 2020
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21759 to 7.x branch. Original message:
What does this PR do?
Make API address and Shard ID required in Cloud Foundry settings.
Why is it important?
Having an auto-generated Shard ID leads to duplicated data when trying to scale, increasing the problems of loaded systems. Forcing to set a shard ID makes the user more conscious of the implications of this setting.
API address should be set in a real deployment.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Use cases
With previous default configuration, if someones tries to scale by adding a new instance, with the default configuration, they will use a different shard ID, effectively duplicating the data, and the load of the system.
Making the shard ID mandatory forces the user to be more conscious on the implications of this setting.