Cherry-pick #21593 to 7.x: [Winlogbeat] Remove brittle configuration validation from wineventlog#21691
Merged
leehinman merged 1 commit intoelastic:7.xfrom Oct 13, 2020
Merged
Conversation
…elastic#21593) * Remove brittle configuration validation from wineventlog - removed config keys checking - update unit tests Closes elastic#21220 (cherry picked from commit 5b69349)
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
marc-gr
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21593 to 7.x branch. Original message:
What does this PR do?
Removes brittle configuration keys validation from wineventlog
Why is it important?
configuration keys are different between winlogbeat, filebeat &
agent. The presence of the different keys doesn't affect the validity
of the configuration.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run winlogbeat locally
Related issues