Skip to content

Cherry-pick #21672 to 7.10: [Packetbeat][SIP] Fix function that parses from/to/contact headers#21687

Merged
andrewkroh merged 1 commit intoelastic:7.10from
marc-gr:backport_21672_7.10
Oct 8, 2020
Merged

Cherry-pick #21672 to 7.10: [Packetbeat][SIP] Fix function that parses from/to/contact headers#21687
andrewkroh merged 1 commit intoelastic:7.10from
marc-gr:backport_21672_7.10

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Oct 8, 2020

Cherry-pick of PR #21672 to 7.10 branch. Original message:

What does this PR do?

Fixes the function that parses from/to/contact headers in SIP proto

Why is it important?

When the header comes without display info and the URI is not wrapped by <...> it was causing an out of bounds error.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 8, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21687 opened]

  • Start Time: 2020-10-08T13:29:57.712+0000

  • Duration: 44 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 1079
Skipped 10
Total 1089

@andrewkroh andrewkroh merged commit b144b5d into elastic:7.10 Oct 8, 2020
@zube zube bot removed the [zube]: Done label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants