Cherry-pick #21625 to 7.10: Fix flaky FSWatch/FSScanner tests#21677
Merged
kvch merged 1 commit intoelastic:7.10from Oct 8, 2020
Merged
Cherry-pick #21625 to 7.10: Fix flaky FSWatch/FSScanner tests#21677kvch merged 1 commit intoelastic:7.10from
kvch merged 1 commit intoelastic:7.10from
Conversation
## What does this PR do? Unit tests in for `fswatch.go` do not depend on the order of the returned events anymore. Closes elastic#21489 (cherry picked from commit 4754602)
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
jsoriano
approved these changes
Oct 8, 2020
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21625 to 7.10 branch. Original message:
What does this PR do?
Unit tests in for
fswatch.godo not depend on the order of the returned events anymore.Why is it important?
The tests have been flaky.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #21489