Skip to content

Cherry-pick to 7.10: docs: update generate_fields_docs.py (#21359)#21662

Merged
bmorelli25 merged 1 commit intoelastic:7.10from
bmorelli25:backport/7.10/pr-21359
Oct 13, 2020
Merged

Cherry-pick to 7.10: docs: update generate_fields_docs.py (#21359)#21662
bmorelli25 merged 1 commit intoelastic:7.10from
bmorelli25:backport/7.10/pr-21359

Conversation

@bmorelli25
Copy link
Copy Markdown
Member

Backports the following commits to 7.10:

@bmorelli25 bmorelli25 requested a review from a team as a code owner October 7, 2020 20:19
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 7, 2020
@bmorelli25 bmorelli25 added Team:Docs Label for the Observability docs team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 7, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-docs (Team:Docs)

Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25
Copy link
Copy Markdown
Member Author

bmorelli25 commented Oct 12, 2020

@elastic/uptime, I don't have merge privileges until one of you approves this; can someone take a look when they have a sec?

I could merge all of these other backports, but not this one for some reason 🤷

Copy link
Copy Markdown
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, because this seems a routine change that is being applied across all beats and my team was the only one required for CODEOWNER review.

@bmorelli25 bmorelli25 merged commit 5e5c225 into elastic:7.10 Oct 13, 2020
@bmorelli25 bmorelli25 deleted the backport/7.10/pr-21359 branch October 13, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Docs Label for the Observability docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants