Cherry-pick to 7.10: Add add_observer_metadata geo.name to Quickstart (#21501)#21640
Merged
EamonnTP merged 1 commit intoelastic:7.10from Oct 14, 2020
Merged
Conversation
* Add `add_observer_metadata` `geo.name` to Quickstart The observer location is very important in the Uptime app and the out-of-the-box machine learning job. * Update getting-started.asciidoc The instructions about editing heartbeat.yml were too wordy * tighten it up! Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25
approved these changes
Oct 7, 2020
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
|
Author
|
@elastic/uptime, I can't merge until one from the team approves this. When you have time, can someone take a look? For some reason, I could merge the other backports, but not this one. |
Member
Hmmm. I ran into the same problem on another PR with 7.10 and the Uptime team. |
Contributor
|
Pinging @elastic/obs-docs (Team:Docs) |
Author
|
Hi @andrewvc. If you have time today, could you take a look at this PR? Thanks! |
Contributor
|
@EamonnTP this build went ok, so I think we are good to go |
Author
|
Thanks @andresrc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.10:
add_observer_metadatageo.nameto Quickstart (Addadd_observer_metadatageo.nameto Quickstart #21501)