Skip to content

Cherry-pick #21454 to 7.x: Update Filebeat module expected logs files#21526

Merged
andrewkroh merged 1 commit intoelastic:7.xfrom
andrewkroh:backport_21454_7.x
Oct 7, 2020
Merged

Cherry-pick #21454 to 7.x: Update Filebeat module expected logs files#21526
andrewkroh merged 1 commit intoelastic:7.xfrom
andrewkroh:backport_21454_7.x

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Oct 5, 2020

Cherry-pick of PR #21454 to 7.x branch. Original message:

What does this PR do?

Elasticsearch added country_name to the list of default field for geo in elastic/elasticsearch#62915. So the expected files needed updated.

Why is it important?

Fixes broken Filebeat module.

Checklist

  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 5, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 5, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 5, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21526 updated]

  • Start Time: 2020-10-07T18:27:45.082+0000

  • Duration: 69 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 4414
Skipped 570
Total 4984

@andrewkroh
Copy link
Copy Markdown
Member Author

run tests

@andrewkroh
Copy link
Copy Markdown
Member Author

This is failing because elastic/elasticsearch#63257 is not merged yet.

@andrewkroh
Copy link
Copy Markdown
Member Author

run tests

@andrewkroh
Copy link
Copy Markdown
Member Author

run tests

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

Thank you for fixing this!

@andrewkroh
Copy link
Copy Markdown
Member Author

The build is failing with errors like

2020-10-07T10:48:29.658-0200 ERROR [publisher_pipeline_output] pipeline/output.go:154 Failed to connect to backoff(elasticsearch(http://elasticsearch:9200)): Connection marked as failed because the onConnect callback failed: 1 error: Error loading pipeline for fileset cyberark/corepas: couldn't load pipeline: couldn't load json. Error: 400 Bad Request: {"error":{"root_cause":[{"type":"script_exception","reason":"compile error","processor_type":"append","script_stack":["... ains(ctx?.host?.hostname server?.domain)) || ctx?. ..."," ^---- HERE"],"script":"ctx?.host?.hostname != null && ctx.host?.hostname != '' && ((ctx?.related?.hosts instanceof List && !ctx?.related?.hosts.contains(ctx?.host?.hostname server?.domain)) || ctx?.related?.hosts != ctx?.host?.hostname server?.domain)","lang":"painless","position":{"offset":150,"start":125,"end":175}}],"type":"script_exception","reason":"compile error","processor_type":"append","script_stack":["... ains(ctx?.host?.hostname server?.domain)) || ctx?. ..."," ^---- HERE"],"script":"ctx?.host?.hostname != null && ctx.host?.hostname != '' && ((ctx?.related?.hosts instanceof List && !ctx?.related?.hosts.contains(ctx?.host?.hostname server?.domain)) || ctx?.related?.hosts != ctx?.host?.hostname server?.domain)","lang":"painless","position":{"offset":150,"start":125,"end":175},"caused_by":{"type":"illegal_argument_exception","reason":"invalid sequence of tokens near ['server'].","caused_by":{"type":"no_viable_alt_exception","reason":null}}},"status":400}. Response body: {"error":{"root_cause":[{"type":"script_exception","reason":"compile error","processor_type":"append","script_stack":["... ains(ctx?.host?.hostname server?.domain)) || ctx?. ..."," ^---- HERE"],"script":"ctx?.host?.hostname != null && ctx.host?.hostname != '' && ((ctx?.related?.hosts instanceof List && !ctx?.related?.hosts.contains(ctx?.host?.hostname server?.domain)) || ctx?.related?.hosts != ctx?.host?.hostname server?.domain)","lang":"painless","position":{"offset":150,"start":125,"end":175}}],"type":"script_exception","reason":"compile error","processor_type":"append","script_stack":["... ains(ctx?.host?.hostname server?.domain)) || ctx?. ..."," ^---- HERE"],"script":"ctx?.host?.hostname != null && ctx.host?.hostname != '' && ((ctx?.related?.hosts instanceof List && !ctx?.related?.hosts.contains(ctx?.host?.hostname server?.domain)) || ctx?.related?.hosts != ctx?.host?.hostname server?.domain)","lang":"painless","position":{"offset":150,"start":125,"end":175},"caused_by":{"type":"illegal_argument_exception","reason":"invalid sequence of tokens near ['server'].","caused_by":{"type":"no_viable_alt_exception","reason":null}}},"status":400}

@marc-gr
Copy link
Copy Markdown
Contributor

marc-gr commented Oct 7, 2020

Seems to be an error introduced in the last changes I did to some of the pipelines, will check if there are others and open a PR fixing it.

Elasticsearch added country_name to the list of default field for geo in elastic/elasticsearch#62915. So the expected files needed updated.

(cherry picked from commit 13a5463)
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green 👍

@andrewkroh andrewkroh merged commit a3011ec into elastic:7.x Oct 7, 2020
@zube zube bot removed the [zube]: Done label Jan 6, 2021
@andrewkroh andrewkroh deleted the backport_21454_7.x branch January 14, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants