Skip to content

Cherry-pick #21406 to 7.x: Split index restrictions into type,dataset, namespace parts #21459

Merged
michalpristas merged 1 commit intoelastic:7.xfrom
michalpristas:backport_21406_7.x
Oct 2, 2020
Merged

Cherry-pick #21406 to 7.x: Split index restrictions into type,dataset, namespace parts #21459
michalpristas merged 1 commit intoelastic:7.xfrom
michalpristas:backport_21406_7.x

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Oct 2, 2020

Cherry-pick of PR #21406 to 7.x branch. Original message:

What does this PR do?

This PR does not apply same restrictions set on all parts of resulting index and follows 20/100/100 bytes length requirement for type, dataset and namespace

Why is it important?

Makes rules in par with the ones applied at fleet level

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas
[Ingest Manager] Split index restrictions into type,dataset, namespac…
1e8ca37 
…e parts (elastic#21406)

[Ingest Manager] Split index restrictions into type,dataset, namespace parts (elastic#21406)
@michalpristas michalpristas self-assigned this Oct 2, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 2, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 2, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21459 opened]

  • Start Time: 2020-10-02T08:07:25.753+0000

  • Duration: 35 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 4
Total 1388

ph
ph approved these changes Oct 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM

@michalpristas michalpristas merged commit 6f512d3 into elastic:7.x Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ph ph ph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michalpristas michalpristas

Labels

backport Ingest Management:beta2 Group issues for ingest management beta2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalpristas @elasticmachine @ph