Cherry-pick #21085 to 7.x: Adds a default for failure_cache.min_ttl#21353
Merged
andrewkroh merged 1 commit intoelastic:7.xfrom Oct 1, 2020
Merged
Cherry-pick #21085 to 7.x: Adds a default for failure_cache.min_ttl#21353andrewkroh merged 1 commit intoelastic:7.xfrom
andrewkroh merged 1 commit intoelastic:7.xfrom
Conversation
* Adds a default for failure_cache.min_ttl * Parse YAML as inline + fix default value Fixes elastic#21103 Co-authored-by: Adrian Serrano <adrisr83@gmail.com> (cherry picked from commit ddfe085)
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
kaiyan-sheng
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21085 to 7.x branch. Original message:
What does this PR do?
It adds a default value for the
failure_cache.min_ttlsetting added in #18986. The default value is the same as that for thesuccess_cache.min_ttlsetting.Why is it important?
As reported in https://discuss.elastic.co/t/fail-to-unpack-the-dns-configuration-requires-duration-1-accessing-processors-0-dns-min-ttl/248453/1, before the change in this PR, when a user configures the DNS processor minimally like so:
The following error is thrown:
Resolves #21103.