Cherry-pick #21072 to 7.x: Do not need Google credentials before using it#21075
Merged
kvch merged 1 commit intoelastic:7.xfrom Sep 14, 2020
Merged
Cherry-pick #21072 to 7.x: Do not need Google credentials before using it#21075kvch merged 1 commit intoelastic:7.xfrom
kvch merged 1 commit intoelastic:7.xfrom
Conversation
## What does this PR do? This PR moves retrieving a GCP token to a later stage of running Functionbeat. From now on tokens are only needed when the operations require it. ## Why is it important? Previously user was required to set a proper credentials file under `GOOGLE_APPLICATION_CREDENTIALS` environment variable regardless of the operation. Closes elastic#17329 (cherry picked from commit c2efa09)
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
michalpristas
approved these changes
Sep 14, 2020
Contributor
michalpristas
left a comment
There was a problem hiding this comment.
backport looks good
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21072 to 7.x branch. Original message:
What does this PR do?
This PR moves retrieving a GCP token to a later stage of running Functionbeat. From now on tokens are only needed when the operations require it.
Why is it important?
Previously user was required to set a proper credentials file under
GOOGLE_APPLICATION_CREDENTIALSenvironment variable regardless of the operation.Checklist
- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Make sure that
GOOGLE_APPLICATION_CREDENTIALSis not set. Run the following command and make sure it does not return an error:Related issues
Closes #17329