Cherry-pick #21048 to 7.x: Filebeat: Fix random error on harvester close#21055
Merged
adriansr merged 1 commit intoelastic:7.xfrom Sep 14, 2020
Merged
Cherry-pick #21048 to 7.x: Filebeat: Fix random error on harvester close#21055adriansr merged 1 commit intoelastic:7.xfrom
adriansr merged 1 commit intoelastic:7.xfrom
Conversation
This fixes a race condition when a harvester is closed at the same time that its source file size is being calculated. Before this fix, `Error updating file size` errors are randomly printed, because the file handle becomes closed inside the os.Stat call. (cherry picked from commit af6222d)
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
kvch
approved these changes
Sep 10, 2020
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21048 to 7.x branch. Original message:
This fixes a race condition when a harvester is closed at the same time that its source file size is being calculated.
Why is it important?
Random
Error updating file sizeerrors have been reported. Other than that it looks like the bug has no other effect.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
It's easy to trigger this error by removing the Ticker in
monitorFileSizeand busy loop callingh.updateCurrentSize(), with a configuration that usesclose_eofand many files.Logs