Cherry-pick #20603 to 7.x: Fix python deprecation warnings#21007
Merged
jsoriano merged 2 commits intoelastic:7.xfrom Sep 9, 2020
Merged
Cherry-pick #20603 to 7.x: Fix python deprecation warnings#21007jsoriano merged 2 commits intoelastic:7.xfrom
jsoriano merged 2 commits intoelastic:7.xfrom
Conversation
Solve python deprecation warnings, and make python tests to fail if deprecated code is added. Changes here: * Add error::DeprecationWarning to pytest's filterwarnings (so tests fail if use deprecated code). * Add pytest.ini to the list of files that trigger all CI builds. * Refactor tests to don't require deprecated assertDictContainsSubset. * Update autopep8 to latest version, and run it once with -a (aggresive). * Solve some other deprecation warnings not solved automatically by autopep8 -a. (cherry picked from commit bed3964)
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
sayden
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20603 to 7.x branch. Original message:
What does this PR do?
Solve python deprecation warnings, and make python tests to fail if deprecated code is added.
Summary of changes:
error::DeprecationWarningto pytest'sfilterwarnings(so tests fail if use deprecated code).pytest.inito the list of files that trigger all CI builds.assertDictContainsSubset.-a(aggresive).autopep8 -a.Why is it important?
To avoid introducing deprecated Python code on testing.
Checklist
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues