Skip to content

Cherry-pick #20952 to 7.x: Align introspect-inspect naming in code#20954

Merged
michalpristas merged 1 commit intoelastic:7.xfrom
michalpristas:backport_20952_7.x
Sep 7, 2020
Merged

Cherry-pick #20952 to 7.x: Align introspect-inspect naming in code#20954
michalpristas merged 1 commit intoelastic:7.xfrom
michalpristas:backport_20952_7.x

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Sep 3, 2020

Cherry-pick of PR #20952 to 7.x branch. Original message:

What does this PR do?

As we changed introspect command to inspect there was a misalignment between names in code and in CLI.
This PR aligns that.

Why is it important?

Improves readability

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas self-assigned this Sep 3, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 3, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 3, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 3, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20954 opened, Started by user Michal Pristas, Rebuilds build #2]

  • Start Time: 2020-09-07T07:31:26.106+0000

  • Duration: 34 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 1577
Skipped 3
Total 1580

blakerouse
blakerouse approved these changes Sep 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit 7b7127d into elastic:7.x Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalpristas @elasticmachine @blakerouse