Cherry-pick #20915 to 7.x: [Autodiscover] Handle input-not-finished errors in config reload#20928
Merged
ChrsMark merged 3 commits intoelastic:7.xfrom Sep 3, 2020
Merged
Conversation
…stic#20915) (cherry picked from commit 35e6b60)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
jsoriano
reviewed
Sep 3, 2020
Comment on lines
+187
to
+188
| - [Autodiscover] Handle input-not-finished errors in config reload. {pull}20915[20915] | ||
| - Explicitly detect missing variables in autodiscover configuration, log them at the debug level. {issue}20568[20568] {pull}20898[20898] |
Member
There was a problem hiding this comment.
This line is not related to this change.
jsoriano
reviewed
Sep 3, 2020
c83f552 to
057780a
Compare
jsoriano
approved these changes
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20915 to 7.x branch. Original message:
What does this PR do?
This PR adds special error handling in config reload flow to handle state errors specially by not logging in ERROR level to avoid confusion in logging.
Current state:
Patch:
Why is it important?
To avoid confusion in logging because of a non actual ERROR is logged as an ERROR. We need to log with lower severity this kind of errors.
How to test this PR locally
Using testing steps from #20305.
Related issues