Skip to content

Cherry-pick #20649 to 7.x: Kubernetes state_daemonset metricset for Metricbeat#20900

Merged
jsoriano merged 2 commits intoelastic:7.xfrom
jsoriano:backport_20649_7.x
Sep 3, 2020
Merged

Cherry-pick #20649 to 7.x: Kubernetes state_daemonset metricset for Metricbeat#20900
jsoriano merged 2 commits intoelastic:7.xfrom
jsoriano:backport_20649_7.x

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Sep 1, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20649 to 7.x branch. Original message:

What does this PR do?

Implements state_daemonset for the Metricbeat Kubernetes module, in the model of state_deployment, state_replicaset etc.

Why is it important?

Allows monitoring (and alerting) of DaemonSet replica status. Gives DaemonSet similar Metricbeat coverage to the other standard pod controllers (ReplicaSet etc).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Generated documentation is sufficient and correct.

How to test this PR locally

MODULE=kubernetes mage -v test in the metricbeat directory.

Test result may be affected by #20627

Related issues

Use cases

Comprehensive alerting for all standard pod controllers. Alert when insufficient available pods exist for a DaemonSet, (not just Deployment, ReplicaSet, and StatefulSet).

@jsoriano
Kubernetes state_daemonset metricset for Metricbeat (elastic#20649)
0159bac 
Implements state_daemonset for the Metricbeat Kubernetes module, in
the model of state_deployment, state_replicaset etc.

(cherry picked from commit 2a0e099)
@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Sep 1, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 1, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 1, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 1, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20900 updated]

  • Start Time: 2020-09-01T18:41:08.562+0000

  • Duration: 68 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 3144
Skipped 686
Total 3830

kaiyan-sheng
kaiyan-sheng reviewed Sep 1, 2020
View reviewed changes
@jsoriano jsoriano merged commit 4afcb74 into elastic:7.x Sep 3, 2020
@zube zube bot removed the [zube]: Done label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@kaiyan-sheng kaiyan-sheng Awaiting requested review from kaiyan-sheng

Assignees

No one assigned

Labels

backport Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsoriano @elasticmachine @ChrsMark @kaiyan-sheng