Skip to content

Cherry-pick #20788 to 7.x: [Filebeat] Remove duplicate ListGroupsForUsers in aws/cloudtrail#20841

Merged
leehinman merged 1 commit intoelastic:7.xfrom
leehinman:backport_20788_7.x
Aug 31, 2020
Merged

Cherry-pick #20788 to 7.x: [Filebeat] Remove duplicate ListGroupsForUsers in aws/cloudtrail#20841
leehinman merged 1 commit intoelastic:7.xfrom
leehinman:backport_20788_7.x

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Aug 27, 2020

Cherry-pick of PR #20788 to 7.x branch. Original message:

What does this PR do?

Removes duplicate ListGroupsForUsers in aws/cloudtrail ingest pipeline.

Why is it important?

Not causing a problem in Filebeat but does when used as a package with
elastic agent. Files should be kept in sync so diffing is easier and
experience is the same for users.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files

  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=aws TESTING_FILEBEAT_FILESETS=cloudtrail mage -v pythonIntegTest

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 27, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20841 opened]

  • Start Time: 2020-08-27T20:31:33.011+0000

  • Duration: 71 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 2473
Skipped 388
Total 2861

@leehinman leehinman merged commit a9160eb into elastic:7.x Aug 31, 2020
@leehinman leehinman deleted the backport_20788_7.x branch October 5, 2020 19:06
@zube zube bot removed the [zube]: Done label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants