Cherry-pick #20791 to 7.x: Check host fields type before converting to common.MapStr#20834
Merged
kaiyan-sheng merged 1 commit intoelastic:7.xfrom Aug 31, 2020
kaiyan-sheng:backport_20791_7.x
Merged
Cherry-pick #20791 to 7.x: Check host fields type before converting to common.MapStr#20834kaiyan-sheng merged 1 commit intoelastic:7.xfrom kaiyan-sheng:backport_20791_7.x
kaiyan-sheng merged 1 commit intoelastic:7.xfrom
kaiyan-sheng:backport_20791_7.x
Conversation
(cherry picked from commit ad7689c)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
narph
approved these changes
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20791 to 7.x branch. Original message:
What does this PR do?
This PR is to address comment for checking
hostFieldstype before converting tocommon.MapStr. Directly converting tocommon.MapStrwill panic if the host field is not acommon.MapStr.Why is it important?
Filebeat can handle arbitrary data so it's not guaranteed host field is
common.MapStrtype and this will cause a panic.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.