Skip to content

Cherry-pick to 7.x: Add FLEET_ENROLL_INSECURE env var to expose --insecure CLI option (#20713)#20732

Merged
ycombinator merged 1 commit intoelastic:7.xfrom
ycombinator:backport/7.x/pr-20713
Aug 25, 2020
Merged

Cherry-pick to 7.x: Add FLEET_ENROLL_INSECURE env var to expose --insecure CLI option (#20713)#20732
ycombinator merged 1 commit intoelastic:7.xfrom
ycombinator:backport/7.x/pr-20713

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

@ycombinator ycombinator self-assigned this Aug 21, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 21, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 21, 2020
Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm tempted to say that we should have that also in 7.9 as otherwise 7.9 agent as Docker container can't be used in some basic test environments.

@ph WDYT?

@ph
Copy link
Copy Markdown
Contributor

ph commented Aug 21, 2020

@ycombinator @ruflin Yes, adding this to 7.9, its a bug not a new feature IMHO

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 21, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20732 updated]

  • Start Time: 2020-08-25T17:30:29.724+0000

  • Duration: 74 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 18001
Skipped 1853
Total 19854

@ycombinator
Copy link
Copy Markdown
Contributor Author

@ruflin @ph Okay, backporting to 7.9: #20740.

@ycombinator
Copy link
Copy Markdown
Contributor Author

jenkins, test this please

…0713)

* Add FLEET_ENROLL_INSECURE env var to expose --insecure CLI option

* Adding CHANGELOG entry

* Adding issue to CHANGELOG entry
# Conflicts:
#	x-pack/elastic-agent/CHANGELOG.asciidoc
@ycombinator ycombinator merged commit 289ac78 into elastic:7.x Aug 25, 2020
@ycombinator ycombinator deleted the backport/7.x/pr-20713 branch August 25, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants