Skip to content

Cherry-pick #20586 to 7.x: Use older version of github.com/dop251/goja_nodejs#20598

Merged
kvch merged 1 commit intoelastic:7.xfrom
kvch:backport_20586_7.x
Aug 14, 2020
Merged

Cherry-pick #20586 to 7.x: Use older version of github.com/dop251/goja_nodejs#20598
kvch merged 1 commit intoelastic:7.xfrom
kvch:backport_20586_7.x

Conversation

@kvch
Copy link
Copy Markdown
Contributor

@kvch kvch commented Aug 14, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20586 to 7.x branch. Original message:

What does this PR do?

This PR pins the version of github.com/dop251/goja_nodejs.

Why is it important?

The recent update of this library leads to the following error when generating custom Beats:

mage GenerateCustomBeat
# github.com/dop251/goja_nodejs/require
/home/n/go/pkg/mod/github.com/dop251/goja_nodejs@v0.0.0-20200728182148-d8e650e3b24d/require/resolve.go:169:13: undefined: goja.StackFrame
/home/n/go/pkg/mod/github.com/dop251/goja_nodejs@v0.0.0-20200728182148-d8e650e3b24d/require/resolve.go:170:21: r.runtime.CaptureCallStack undefined (type *goja.Runtime has no field or method CaptureCallStack)
Error: error compiling magefiles

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Aug 14, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 14, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 14, 2020

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 14, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 14, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20598 opened]

  • Start Time: 2020-08-14T08:33:50.656+0000

  • Duration: 92 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 17784
Skipped 1853
Total 19637

@kvch kvch merged commit 35aeb0d into elastic:7.x Aug 14, 2020
@zube zube bot removed the [zube]: Done label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kvch @elasticmachine @kaiyan-sheng