Skip to content

Cherry-pick #19899 to 7.x: Update container name for the azure filesets#20421

Merged
narph merged 1 commit intoelastic:7.xfrom
narph:backport_19899_7.x
Aug 4, 2020
Merged

Cherry-pick #19899 to 7.x: Update container name for the azure filesets#20421
narph merged 1 commit intoelastic:7.xfrom
narph:backport_19899_7.x

Conversation

@narph
Copy link
Copy Markdown
Contributor

@narph narph commented Aug 4, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #19899 to 7.x branch. Original message:

What does this PR do?

creates a specific container name based on the azure fileset and the eventhub name

Why is it important?

Users could use same eventhub to export different types of logs, that would mean the same container name would be used for multiple azure input instances. This would avoid the case.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph
Update container name for the azure filesets (elastic#19899)
8e1f40d 
* update container name

* update changelog

(cherry picked from commit 8934bc5)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 4, 2020
@narph narph self-assigned this Aug 4, 2020
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Aug 4, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 4, 2020

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 4, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20421 opened]

  • Start Time: 2020-08-04T10:34:58.823+0000

  • Duration: 54 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 2434
Skipped 385
Total 2819

@narph narph merged commit 23ec7b9 into elastic:7.x Aug 4, 2020
@narph narph deleted the backport_19899_7.x branch August 4, 2020 13:53
@zube zube bot removed the [zube]: Done label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@narph narph

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@narph @elasticmachine @kaiyan-sheng