Skip to content

Cherry-pick to 7.x: Support "cluster" scope in Metricbeat elasticsearch module (#18547)#20413

Merged
ycombinator merged 1 commit intoelastic:7.xfrom
ycombinator:backport/7.x/pr-18547
Aug 4, 2020
Merged

Cherry-pick to 7.x: Support "cluster" scope in Metricbeat elasticsearch module (#18547)#20413
ycombinator merged 1 commit intoelastic:7.xfrom
ycombinator:backport/7.x/pr-18547

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* Adding configuration for hosts_mode

* Only perform master check in HostsModeNode

* Only ask the node if it's the master node if we're in HostsModeNode

* Unpack host_mode string into enum

* Adding some specific TODOs in node_stats code

* Updating x-pack/metricbeat reference config

* Set correct service URI

* Get master node ID

* Adding CHANGELOG entry

* Rename hosts_mode => scope

* Removing stale TODO comment

* Adding docs

* Refactoring common code into helper method

* Do not set service URI up front

* Updating documentation per review

* Remove comments from doc examples

* Adding configuration for hosts_mode

* Set correct service URI

* Adding CHANGELOG entry

* Rename hosts_mode => scope

* Do not set service URI up front

* Update metricbeat/docs/modules/elasticsearch.asciidoc

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

* Update metricbeat/module/elasticsearch/_meta/docs.asciidoc

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

* Update reference config

* Cleaning up CHANGELOG

* Updating generated files

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@ycombinator ycombinator self-assigned this Aug 3, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 3, 2020
@ycombinator ycombinator added backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Aug 3, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 3, 2020
@ycombinator ycombinator requested a review from a team August 3, 2020 19:26
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20413 opened]

  • Start Time: 2020-08-03T19:27:16.870+0000

  • Duration: 73 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 3128
Skipped 696
Total 3824

@ycombinator ycombinator merged commit 903750c into elastic:7.x Aug 4, 2020
@ycombinator ycombinator deleted the backport/7.x/pr-18547 branch August 4, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants