Cherry-pick #20396 to 7.x: [Filebeat][SophosXG Module] Renaming module and fileset#20408
Merged
adriansr merged 2 commits intoelastic:7.xfrom Aug 4, 2020
Merged
Cherry-pick #20396 to 7.x: [Filebeat][SophosXG Module] Renaming module and fileset#20408adriansr merged 2 commits intoelastic:7.xfrom
adriansr merged 2 commits intoelastic:7.xfrom
Conversation
renaming sophosxg module to sophos, and renaming fileset to better support future filesets (cherry picked from commit 778a92f)
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
andrewkroh
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20396 to 7.x branch. Original message:
What does this PR do?
Renaming module from SophosXG to Sophos, and fileset from firewall to XG.
This allows us to easier add more fileset under the more generally named Sophos module
Why is it important?
Makes adding new filesets to Sophos easier and cleaner.
Checklist
- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Module already has a PR Changelog entry, and has not been released yet, so removing the checkbox for changelog
Updated golden files with:
MODULES_PATH=$PWD/module GENERATE=1 INTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false TESTING_FILEBEAT_MODULES=sophos nosetests -v -s tests/system/test_xpack_modules.py