Cherry-pick #20163 to 7.x: [Elastic Agent] Add skeleton for client/server for agent control protocol#20401
Merged
blakerouse merged 1 commit intoelastic:7.xfrom Aug 4, 2020
Merged
Conversation
…ocol (elastic#20163) * Add protocl to control Elastic Agent. * Fix CI with protoc. * Remove CI changes. * Start on the control server code. * More client/server work. * More work. * Add test. * Fix vet issues. * Fix permissions on unix socket. Add comment to Windows npipe. (cherry picked from commit 77a8472)
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Contributor
Author
|
The Windows failure is known, for this cherry-pick PR. The next cherry-pick PR that follows this, fixes that failure. |
| // Address returns the address to connect to Elastic Agent daemon. | ||
| func Address() string { | ||
| data := paths.Data() | ||
| return fmt.Sprintf("unix://%s", filepath.Join(data, "agent.sock")) |
Contributor
Author
There was a problem hiding this comment.
The control server isn't started in this PR. The cherry-pick after this PR actually starts the control server, I will place the #20426 into that cherry-pick to 7.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20163 to 7.x branch. Original message:
What does this PR do?
Adds the required skeleton code to allow Elastic Agent to connect and receive information from a running Elastic Agent daemon. Includes the implementation for
Versionalong with a test to ensure that client/server communication works.Why is it important?
So
elastic-agent {subcommands}can talk to the running daemon.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues