Cherry-pick #20356 to 7.x: Prepare home directories for docker images in a different stage#20399
Merged
jsoriano merged 1 commit intoelastic:7.xfrom Aug 3, 2020
Merged
Conversation
…tic#20356) Files included in the home directory of the docker images need some changes on permissions and ownerships after being copied. If this is done as a COPY and a RUN, it creates two layers with all the files, that are included in the final image, increasing its size. Move the preparation of the home directory to a different stage, so in the final image it is done as an only COPY operation. (cherry picked from commit aaf3d7e)
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
kaiyan-sheng
approved these changes
Aug 3, 2020
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Backport looks good. CI failed with TestDockerStart: docker_integration_test.go:125: Timeout waiting for provider events, doesn't seem to be related?!
Member
Author
This is a flaky test #20360, not related. |
Contributor
|
Good to know! Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20356 to 7.x branch. Original message:
Files included in the home directory of the docker images need some
changes on permissions and ownership after being copied. If this is
done as a COPY and a RUN, it creates two layers with all the files, that
are included in the final image, increasing its size.
Move the preparation of the home directory to a different stage, so in
the final image it is done as an only COPY operation.
This change reduces for example the Metricbeat image size a ~25%,
from 558MB to 418MB. Auditbeat image from 462MB to 370MB.
How to test