Skip to content

Cherry-pick #20370 to 7.x: Check expand_event_list_from_field when json in map[string]interface{} format#20374

Merged
kaiyan-sheng merged 1 commit intoelastic:7.xfrom
kaiyan-sheng:backport_20370_7.x
Jul 31, 2020
Merged

Cherry-pick #20370 to 7.x: Check expand_event_list_from_field when json in map[string]interface{} format#20374
kaiyan-sheng merged 1 commit intoelastic:7.xfrom
kaiyan-sheng:backport_20370_7.x

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 31, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20370 to 7.x branch. Original message:

What does this PR do?

When json is in map[string]interface{} format, s3 input should also check for expand_event_list_from_field config parameter.
With this PR, cloudtrail fileset is working again:
Screen Shot 2020-07-30 at 7 11 09 PM

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jul 31, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 31, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 31, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 31, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 31, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 31, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20374 opened]

  • Start Time: 2020-07-31T03:03:07.626+0000

  • Duration: 56 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 2434
Skipped 385
Total 2819

@kaiyan-sheng kaiyan-sheng merged commit b9a5aa7 into elastic:7.x Jul 31, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_20370_7.x branch July 31, 2020 13:09
@zube zube bot removed the [zube]: Done label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

backport Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaiyan-sheng @elasticmachine @ChrsMark