You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cherry-pick of PR #19974 to 7.x branch. Original message:
Bug
What does this PR do?
Everytime the kubelet does a check for node health it posts an update to the node status. Each change even if overall status doesnt change then it causes the metricset to restart. This PR adds a watcher option to register a func that checks in detail if the update is valid or not.
Why is it important?
This makes sure that the kubelet status updates dont prompt a restart unless the overall status changes.
Checklist
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
[2020-07-29T14:34:02.077Z] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-07-29T14:34:02.077Z] at java.lang.Thread.run(Thread.java:748)
[2020-07-29T14:34:02.077Z]
[2020-07-29T14:34:02.524Z] Failed in branch Generators
[2020-07-29T14:34:04.465Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats
[2020-07-29T14:34:04.817Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-29T14:34:04.841Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Lint
[2020-07-29T14:34:05.003Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Winlogbeat-oss
[2020-07-29T14:34:05.159Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-07-29T14:34:05.321Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-07-29T14:34:05.480Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Dockerlogbeat
[2020-07-29T14:34:05.641Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Journalbeat-oss
[2020-07-29T14:34:05.800Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-07-29T14:34:05.961Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-07-29T14:34:06.118Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Packetbeat-Linux
[2020-07-29T14:34:06.275Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-07-29T14:34:06.432Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-07-29T14:34:06.590Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-07-29T14:34:06.754Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Heartbeat-oss
[2020-07-29T14:34:06.927Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-07-29T14:34:07.105Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-07-29T14:34:07.284Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-07-29T14:34:07.443Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-07-29T14:34:07.599Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-07-29T14:34:07.764Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Filebeat-Windows
[2020-07-29T14:34:07.934Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Libbeat-x-pack
[2020-07-29T14:34:08.093Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-Windows
[2020-07-29T14:34:08.262Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-07-29T14:34:08.415Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-07-29T14:34:08.570Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-07-29T14:34:08.735Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-07-29T14:34:08.890Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Libbeat-oss
[2020-07-29T14:34:09.044Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-07-29T14:34:09.200Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-07-29T14:34:09.350Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Filebeat-oss
[2020-07-29T14:34:09.505Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Filebeat-x-pack
[2020-07-29T14:34:09.672Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-07-29T14:34:09.829Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-07-29T14:34:09.985Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-07-29T14:34:10.141Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-07-29T14:34:10.298Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-07-29T14:34:10.453Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-OSS-Python-Integration-tests
[2020-07-29T14:34:10.608Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests
[2020-07-29T14:34:10.765Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Functionbeat-Mac-OS-X-x-pack
[2020-07-29T14:34:10.918Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Packetbeat-Mac-OS-X
[2020-07-29T14:34:11.069Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Heartbeat-Mac-OS-X
[2020-07-29T14:34:11.224Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-07-29T14:34:11.402Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Heartbeat-Windows
[2020-07-29T14:34:11.558Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Functionbeat-Windows
[2020-07-29T14:34:11.719Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Packetbeat-Windows
[2020-07-29T14:34:11.877Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Generators-Metricbeat-Mac-OS-X
[2020-07-29T14:34:12.031Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Generators-Beat-Mac-OS-X
[2020-07-29T14:34:12.480Z] + cat
[2020-07-29T14:34:12.480Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-29T14:34:12.481Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-29T14:34:19.071Z] runbld>>> runbld started
[2020-07-29T14:34:19.071Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-29T14:34:20.986Z] runbld>>> The following profiles matched the job 'Beats/beats/PR-20310' in order of occurrence in the config (last value wins).
[2020-07-29T14:34:22.383Z] runbld>>> Debug logging enabled.
[2020-07-29T14:34:22.383Z] runbld>>> Storing result
[2020-07-29T14:34:22.383Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-29T14:34:22.383Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200729143422-9AF7374E
[2020-07-29T14:34:22.383Z] runbld>>> Adding system facts.
[2020-07-29T14:34:23.774Z] runbld>>> Adding vcs info for the latest commit: 55b6e23ac7aa19749eaba10a07cfa44f7c1bd300
[2020-07-29T14:34:23.774Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-29T14:34:23.774Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-29T14:34:23.774Z] Processing JUnit reports with runbld...
[2020-07-29T14:34:23.774Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-29T14:34:24.036Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-29T14:34:24.036Z] runbld>>> DURATION: 31ms
[2020-07-29T14:34:24.036Z] runbld>>> STDOUT: 40 bytes
[2020-07-29T14:34:24.036Z] runbld>>> STDERR: 49 bytes
[2020-07-29T14:34:24.036Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-29T14:34:24.036Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats
[2020-07-29T14:34:25.428Z] runbld>>> Storing build metadata:
[2020-07-29T14:34:25.428Z] runbld>>> Adding test report.
[2020-07-29T14:34:25.428Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats
[2020-07-29T14:34:26.375Z] runbld>>> Found 135 test output files
[2020-07-29T14:34:27.323Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-07-29T14:34:27.323Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-07-29T14:34:27.323Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-07-29T14:34:27.323Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-07-29T14:34:27.323Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-07-29T14:34:27.584Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-07-29T14:34:27.584Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20310/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-07-29T14:34:30.139Z] runbld>>> Test output logs contained: Errors: 2 Failures: 16 Tests: 19306 Skipped: 1554
[2020-07-29T14:34:30.139Z] runbld>>> Storing result
[2020-07-29T14:34:30.139Z] runbld>>> FAILURES: 18
[2020-07-29T14:34:34.359Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-29T14:34:34.359Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200729143422-9AF7374E
[2020-07-29T14:34:34.359Z] runbld>>> Email notification disabled by environment variable.
[2020-07-29T14:34:34.359Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-29T14:34:39.985Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-20310
[2020-07-29T14:34:40.200Z] [INFO] getVaultSecret: Getting secrets
[2020-07-29T14:34:40.306Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-29T14:34:41.406Z] + chmod 755 generate-build-data.sh
[2020-07-29T14:34:41.407Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20310/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20310/runs/1 FAILURE 7383999
[2020-07-29T14:34:41.407Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20310/runs/1/steps/?limit=10000 -o steps-info.json
[2020-07-29T14:34:44.635Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20310/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-07-29T14:34:44.635Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20310/runs/1/log/ -o pipeline-log.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19974 to 7.x branch. Original message:
Bug
What does this PR do?
Everytime the kubelet does a check for node health it posts an update to the node status. Each change even if overall status doesnt change then it causes the metricset to restart. This PR adds a watcher option to register a func that checks in detail if the update is valid or not.
Why is it important?
This makes sure that the kubelet status updates dont prompt a restart unless the overall status changes.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues