[Ingest Manager] New Agent structure#20307
Closed
michalpristas wants to merge 16 commits intoelastic:masterfrom
Closed
[Ingest Manager] New Agent structure#20307michalpristas wants to merge 16 commits intoelastic:masterfrom
michalpristas wants to merge 16 commits intoelastic:masterfrom
Conversation
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
blakerouse
reviewed
Jul 29, 2020
| "--path.config", paths.Config(), | ||
| } | ||
| rm := reexec.Manager(rexLogger, reexecPath) | ||
| rm.ReExec(argsOverrides...) |
Contributor
There was a problem hiding this comment.
I don't think this is really going to work on Windows. being that Windows doesn't support proper re-exec.
Running from Powershell will show this weird behavior, where calling elastic-agent run -e will exit back to the shell but the logs keep printing to the terminal.
Running as a service I looks like it would just be an infinite loop. It would keep restarting the service, and the service would then just keep re-exec, because this same binary would be pointed at by the service.
This is a good approach on Unix based systems, but on Windows I don't believe it will work.
What about the symlink idea? That seems like it would work on all OS types, including Windows: https://golang.org/pkg/syscall/?GOOS=windows#CreateSymbolicLink
Contributor
Author
There was a problem hiding this comment.
i will need to test it on windows, symlink is ok but needs to be tested as well. we need to create symlink at the build time or provide some activation script, start script or something similar.
i havent tried but i think that creating a symlink during release would not result in something working when you unpack it locally.
Contributor
Author
|
Succesfully running
|
03f6559 to
a54ed0a
Compare
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does a multiple things.
First thing, it alignes structure of resulting package with the proposal defined in issue #20048
For this to work there were a few changes needed.
First one is having two executables one is at root another at
/data/v7.x.x-abc/directory.The one in root serves just as proxy and executes binary in versioned dir and pass all variables there.
This is achieved by pre-run check, check reads the
.build_hash.txtfile if it's there it redirects control to the binary in versioned directory. if it's not there it continues as usual.Draft, because more tests needs to be done
Test on:
Why is it important?
Step 1 for upgradable agent
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.