Skip to content

Cherry-pick #20245 to 7.x: Cisco ASA: Fix message 106100#20276

Merged
adriansr merged 1 commit intoelastic:7.xfrom
adriansr:backport_20245_7.x
Jul 29, 2020
Merged

Cherry-pick #20245 to 7.x: Cisco ASA: Fix message 106100#20276
adriansr merged 1 commit intoelastic:7.xfrom
adriansr:backport_20245_7.x

Conversation

@adriansr
Copy link
Copy Markdown
Contributor

@adriansr adriansr commented Jul 28, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20245 to 7.x branch. Original message:

What does this PR do?

This updates the parser for Cisco ASA message 106100 so that it doesn't fail when extra information is appended after the port numbers.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Fixes #19350

@adriansr
Cisco ASA: Fix message 106100 (elastic#20245)
0204356 
This updates the parser for Cisco ASA message 106100 so that it doesn't
fail when extra information is appended after the port numbers.

Fixes elastic#19350

(cherry picked from commit ac688ca)
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 28, 2020

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 28, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 28, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20276 opened]

  • Start Time: 2020-07-28T14:12:35.847+0000

  • Duration: 66 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 2464
Skipped 385
Total 2849

@adriansr adriansr merged commit 2cfd69b into elastic:7.x Jul 29, 2020
@zube zube bot removed the [zube]: Done label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

No one assigned

Labels

backport review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adriansr @elasticmachine @andrewkroh