Skip to content

Cherry-pick #20232 to 7.x: [Filebeat Input][HTTP_endpoint] Add possibility to override content-type header#20236

Merged
marc-gr merged 1 commit intoelastic:7.xfrom
marc-gr:backport_20232_7.x
Jul 28, 2020
Merged

Cherry-pick #20232 to 7.x: [Filebeat Input][HTTP_endpoint] Add possibility to override content-type header#20236
marc-gr merged 1 commit intoelastic:7.xfrom
marc-gr:backport_20232_7.x

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Jul 27, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20232 to 7.x branch. Original message:

What does this PR do?

Webhooks like Zoom does not add any content-type headers on incoming requests, the content type now defaults to application/json but is possible to set to another value or null.

This is a preliminary change needed before adding some more validation steps, which will be created in separate PR's

Why is it important?

Adds support for webhooks which does not set content-type headers.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 27, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 27, 2020

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 27, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 27, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-28T09:54:31.682+0000

  • Duration: 70 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 2464
Skipped 385
Total 2849

@P1llus @marc-gr
adding possibility to override content-type checks, it was breaking c…
34c5785 
…ertain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232)

(cherry picked from commit 98a423d)
@marc-gr marc-gr force-pushed the backport_20232_7.x branch from 5f2904d to 34c5785 Compare July 28, 2020 06:55
@marc-gr marc-gr merged commit f449faa into elastic:7.x Jul 28, 2020
@marc-gr marc-gr deleted the backport_20232_7.x branch July 28, 2020 11:07
@zube zube bot removed the [zube]: Done label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leehinman leehinman leehinman approved these changes

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marc-gr @elasticmachine @leehinman @P1llus