Skip to content

Cherry-pick #19551 to 7.x: Fix service start type mapping in windows/service metricset#19878

Merged
narph merged 1 commit intoelastic:7.xfrom
narph:backport_19551_7.x
Jul 15, 2020
Merged

Cherry-pick #19551 to 7.x: Fix service start type mapping in windows/service metricset#19878
narph merged 1 commit intoelastic:7.xfrom
narph:backport_19551_7.x

Conversation

@narph
Copy link
Copy Markdown
Contributor

@narph narph commented Jul 14, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #19551 to 7.x branch. Original message:

What does this PR do?

Fixes start type service mapping.

Why is it important?

Service start type property returned an empty string

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph
Fix service start type mapping in windows/service metricset (elastic#…
3e160e0 
…19551)

* fit service start type

* test

* changelog

(cherry picked from commit 194be7f)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2020
@narph narph self-assigned this Jul 14, 2020
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Jul 14, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 14, 2020

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2020
@narph narph merged commit 0846b6c into elastic:7.x Jul 15, 2020
@narph narph deleted the backport_19551_7.x branch July 15, 2020 09:21
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@narph narph

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@narph @elasticmachine @kaiyan-sheng