Skip to content

Cherry-pick #19587 to 7.x: Refuse invalid stream values in configuration #19866

Merged
michalpristas merged 1 commit intoelastic:7.xfrom
michalpristas:backport_19587_7.x
Jul 14, 2020
Merged

Cherry-pick #19587 to 7.x: Refuse invalid stream values in configuration #19866
michalpristas merged 1 commit intoelastic:7.xfrom
michalpristas:backport_19587_7.x

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Jul 14, 2020

Cherry-pick of PR #19587 to 7.x branch. Original message:

What does this PR do?

Adds a filter which errors out when dataset.name or namespace is empty string.

Why is it important?

Described in #18772

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #18772
Fixes: #17730

@michalpristas
[Ingest Manager] Refuse invalid stream values in configuration (elast…
21a6cf0 
…ic#19587)

* added stream check

* changelog

* fmt

* invalid names

* updated config files

* updated config files

* changes in all config files

* config typo

* small changes

* Update go.sum
@michalpristas michalpristas self-assigned this Jul 14, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 14, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 14, 2020
blakerouse
blakerouse approved these changes Jul 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit b506128 into elastic:7.x Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels

backport enhancement Ingest Management:beta1 Group issues for ingest management beta1 review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalpristas @elasticmachine @blakerouse