Skip to content

Cherry-pick #18940 to 7.x: Add support for appinsights in the metricbeat azure module#19854

Merged
narph merged 1 commit intoelastic:7.xfrom
narph:backport_18940_7.x
Jul 13, 2020
Merged

Cherry-pick #18940 to 7.x: Add support for appinsights in the metricbeat azure module#19854
narph merged 1 commit intoelastic:7.xfrom
narph:backport_18940_7.x

Conversation

@narph
Copy link
Copy Markdown
Contributor

@narph narph commented Jul 13, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #18940 to 7.x branch. Original message:

What does this PR do?

Adds an azure metricset that retrieves azure app insights metrics.

Why is it important?

Adds support for appinsights in the metricbeat azure module

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Using the app insights GET metrics API (https://dev.applicationinsights.io/documentation/Using-the-API/Metrics) users can collect specified metrics.
This metricset can be followed by a light metricset that will collect the most relevant/popular app metrics and dashboards.

Configuration:

- module: azure
  metricsets:
    - app_insights
  enabled: true
  period: 2h
  application_id: ""
  api_key: ""
  metrics:
    - id: ["requests/count", "requests/failed"]
      segment: "request/name"
      aggregation: ["sum"]

Example output:

{
    "@timestamp": "2017-10-12T08:05:34.853Z",
        "azure" : {
        "app_insights" : {
            "metrics" : {
                "requests_failed" : {
                    "sum" : 182
                },
                "request_name" : "GET /favicon.ico"
            },
            "start_date" : "2020-07-12T10:52:11.831Z",
            "end_date" : "2020-07-12T12:52:11.831Z",
            "application_id" : "42cb59a9-d5be-400b-a5c4-69b0a0026ac6"
        }
    },
    "cloud": {
        "provider": "azure"
    },
    "event": {
        "dataset": "azure.app_insights",
        "duration": 115000,
        "module": "azure"
    },
    "metricset": {
        "name": "app_insights",
        "period": 10000
    },
    "service": {
        "type": "azure"
    }
}

@narph
Add support for appinsights in the metricbeat azure module (elastic#1…
9b74900 
…8940)

* app

* changelog

* update

* Revert "update"

This reverts commit 06db76b.

* avoid winio

* fix text

(cherry picked from commit 2efea84)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@narph narph self-assigned this Jul 13, 2020
@narph narph added backport Team:Integrations Label for the Integrations team v7.9.0 labels Jul 13, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 13, 2020

Pinging @elastic/integrations (Team:Integrations)

ycombinator
ycombinator approved these changes Jul 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@narph narph merged commit 4836172 into elastic:7.x Jul 13, 2020
@narph narph deleted the backport_18940_7.x branch July 13, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@narph narph

Labels

backport Team:Integrations Label for the Integrations team v7.9.0 [zube]: Done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@narph @elasticmachine @ycombinator