Cherry-pick #19823 to 7.x: Do not update go.mod during packaging and testing#19833
Merged
kvch merged 1 commit intoelastic:7.xfrom Jul 13, 2020
Merged
Cherry-pick #19823 to 7.x: Do not update go.mod during packaging and testing#19833kvch merged 1 commit intoelastic:7.xfrom
kvch merged 1 commit intoelastic:7.xfrom
Conversation
(cherry picked from commit f91c96f)
|
This pull request doesn't have a |
sayden
approved these changes
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19823 to 7.x branch. Original message:
What does this PR do?
This PR adds
-mod=readonlyto Golang commands.Why is it important?
Now that vendor is no longer part of the repo, Go might accidentally update dependencies during integration testing, updating generated assets and packaging. To avoid it, I have added
-mod=readonlyto these commands.This possibly affects the
apm-serverrepo as well. So CC @elastic/apm-serverChecklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.CC @v1v I believe this PR fixes all our problems with Golang updating reps. But as a safety measure, we should adjust the CIs as well.