Cherry-pick #19433 to 7.8: [MetricBeat] set tags correctly if the dimension value is ARN#19583
Merged
kaiyan-sheng merged 2 commits intoelastic:7.8from Jul 2, 2020
kaiyan-sheng:backport_19433_7.8
Merged
Cherry-pick #19433 to 7.8: [MetricBeat] set tags correctly if the dimension value is ARN#19583kaiyan-sheng merged 2 commits intoelastic:7.8from kaiyan-sheng:backport_19433_7.8
kaiyan-sheng merged 2 commits intoelastic:7.8from
kaiyan-sheng:backport_19433_7.8
Conversation
* fix setting tags when dimension value is arn format in aws cloudwatch module (cherry picked from commit f96ef57)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Contributor
jsoriano
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19433 to 7.8 branch. Original message:
What does this PR do?
This PR is to fix setting resource tags when dimension value is ARN format, I found this issue in
AWS/DDoSProtectionnamespace metrics.Why is it important?
cloudwatch module should set event tags correctly if dimension value is ARN format and
tags.resource_type_filterparam is configuredChecklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Screenshots
test with aws shield service and EIP resource , I have put some demo metrics before running test ,so the namespace is
DDoSProtection. The actual value isAWS/DDoSProtectionif you get metrics that created by aws.