Skip to content

Input v2 stateless manager#19406

Merged
urso merged 2 commits intoelastic:masterfrom
urso:input-v2-stateless-manager
Jun 30, 2020
Merged

Input v2 stateless manager#19406
urso merged 2 commits intoelastic:masterfrom
urso:input-v2-stateless-manager

Conversation

@urso
Copy link
Copy Markdown

@urso urso commented Jun 25, 2020 •
edited by andresrc
Loading

  • Enhancement

What does this PR do?

This change introduced an InputManager for stateless inputs, that do not
require end-to-end ACK or or state stored between restarts

The current state of the full implementation can be seen here and sample inputs based on the new API.

The full list of changes will include:

Test coverage report:

gocov test ./... | gocov report
ok  	github.com/elastic/beats/v7/filebeat/input/v2/input-stateless	0.008s	coverage: 72.2% of statements

github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 configuredInput.Run	 100.00% (6/6)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 NewInputManager	 100.00% (1/1)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 InputManager.Create	 75.00% (3/4)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 @76:8			 75.00% (3/4)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 InputManager.Init	 0.00% (0/1)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 configuredInput.Name	 0.00% (0/1)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless/stateless.go	 configuredInput.Test	 0.00% (0/1)
github.com/elastic/beats/v7/filebeat/input/v2/input-stateless			 --------------------	 72.22% (13/18)

Why is it important?

Filebeat input v2 API support

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@urso urso added review Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Project:Filebeat-Input-v2 Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 labels Jun 25, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 25, 2020

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 25, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 25, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [urso commented: jenkins run the tests please]

  • Start Time: 2020-06-30T13:44:22.181+0000

  • Duration: 27 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 543
Skipped 127
Total 670

@urso urso force-pushed the input-v2-stateless-manager branch from 5eea9c1 to 3e08704 Compare June 26, 2020 13:08
urso added 2 commits June 30, 2020 13:07
Add input-stateless package
03d9b9d 
This change introduced an InputManager for stateless inputs, that do not
require end-to-end ACK or or state stored between restarts.
fix import order
e80b27e
@urso
Copy link
Copy Markdown
Author

urso commented Jun 30, 2020

jenkins run the tests please

@urso urso mentioned this pull request Jul 8, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kvch kvch kvch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kvch kvch

Labels

Filebeat Filebeat Project:Filebeat-Input-v2 review skip-test-plan Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@urso @elasticmachine @kvch @andresrc