Cherry-pick #19346 to 7.8: Add additional time formats to decode_cef#19397
Merged
andrewkroh merged 1 commit intoelastic:7.8from Jun 26, 2020
Merged
Cherry-pick #19346 to 7.8: Add additional time formats to decode_cef#19397andrewkroh merged 1 commit intoelastic:7.8from
andrewkroh merged 1 commit intoelastic:7.8from
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
The date formats in the CEF guide describe the time formats in terms of Java's SimpleTimeFormat class. The `zzz` specifier covers a few additional formats than what are covered by `MST` in Go's time format. Namely on the Go side it was missing support for offsets (e.g. +04, +0400, +04:00). This change additional adds support for the ISO8601 `Z` time zone value (this does not strictly match the CEF guide's format). These are the Java SimpleDateFormats in the CEF guide: MMM dd HH:mm:ss.SSS zzz MMM dd HH:mm:sss.SSS MMM dd HH:mm:ss zzz MMM dd HH:mm:ss MMM dd yyyy HH:mm:ss.SSS zzz MMM dd yyyy HH:mm:ss.SSS MMM dd yyyy HH:mm:ss zzz MMM dd yyyy HH:mm:ss (cherry picked from commit b82829b)
4eec614 to
bd201c9
Compare
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
marc-gr
approved these changes
Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19346 to 7.8 branch. Original message:
What does this PR do?
The date formats in the CEF guide describe the time formats in terms of Java's SimpleTimeFormat class.
The
zzzspecifier covers a few additional formats than what are covered byMSTin Go's time format.Namely on the Go side it was missing support for offsets (e.g. +04, +0400, +04:00). This change additionally
adds support for the ISO8601
Ztime zone value (this does not strictly match the CEF guide's format).For reference these are the Java SimpleDateFormats in the CEF guide:
MMM dd HH:mm:ss.SSS zzz
MMM dd HH:mm:sss.SSS
MMM dd HH:mm:ss zzz
MMM dd HH:mm:ss
MMM dd yyyy HH:mm:ss.SSS zzz
MMM dd yyyy HH:mm:ss.SSS
MMM dd yyyy HH:mm:ss zzz
MMM dd yyyy HH:mm:ss
Why is it important?
It makes the decode_cef parser more closely match the CEF guide specification.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.