Skip to content

Cherry-pick #19134 to 7.x: Fix tags for coredns/envoyproxy#19299

Merged
andrewkroh merged 2 commits intoelastic:7.xfrom
andrewkroh:backport_19134_7.x
Jun 26, 2020
Merged

Cherry-pick #19134 to 7.x: Fix tags for coredns/envoyproxy#19299
andrewkroh merged 2 commits intoelastic:7.xfrom
andrewkroh:backport_19134_7.x

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Jun 18, 2020

Cherry-pick of PR #19134 to 7.x branch. Original message:

What does this PR do?

When {{ .tags }} is evaluated in the module config it not written in the correct format.
This fixes that issue and also conditionally enables publisher_pipeline.disable_host
based on whether tags contains forwarded to be consistent with every other module
that allows for var.tags to be set (relates: #13920).

For example (https://play.golang.org/p/LUr-X94msd1):

var.tags: [foo, bar]

will be written into the config as

tags: [foo bar]

which is a single value array containing the string "foo bar" rather than two tags.

Why is it important?

If a user specified more than one tag in a module config then they would not have had the expect tags in their events.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

When {{ .tags }} is evaluated in the module config it not written in the correct format.
This fixes that issue and also conditionally enables `publisher_pipeline.disable_host`
based on whether tags contains `forwarded` to be consistent with every other module
that allows for `var.tags` to be set (relates: elastic#13920).

For example (https://play.golang.org/p/LUr-X94msd1):

    var.tags: [foo, bar]

will be written into the config as

    tags: [foo bar]

which is a single value array containing the string "foo bar" rather than two tags.

(cherry picked from commit b48c388)
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 18, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19299 opened]

  • Start Time: 2020-06-18T19:54:10.727+0000

  • Duration: 46 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 2344
Skipped 382
Total 2726

@andrewkroh andrewkroh merged commit 3c2b052 into elastic:7.x Jun 26, 2020
@andrewkroh andrewkroh deleted the backport_19134_7.x branch January 14, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants