Skip to content

Add support for cloudfoundry metrics collection using consumer v1 API#19268

Merged
jsoriano merged 11 commits intoelastic:masterfrom
jsoriano:cloudfoundry-metricbeat-v1
Jun 24, 2020
Merged

Add support for cloudfoundry metrics collection using consumer v1 API#19268
jsoriano merged 11 commits intoelastic:masterfrom
jsoriano:cloudfoundry-metricbeat-v1

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Jun 18, 2020

What does this PR do?

Continues with #19125 to add support to Cloud Foundry consumer v1 API in Metricbeat too.

version can be used to select if v1 or v2 version should be used.

Why is it important?

We already support the v2 API, but we saw that this API is not reliable enough (see #18202 and #18282).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Run metricbeat with the cloudfoundry input and check that it collects events. Try these combinations of the version option:
    • No version option (what would use v1)
    • version: v1.
    • version: v2.
    • For other values of version it should fail to start.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 18, 2020
@jsoriano jsoriano added [zube]: In Progress in progress Pull request is currently in progress. Team:Platforms Label for the Integrations - Platforms team labels Jun 18, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 18, 2020
@jsoriano jsoriano self-assigned this Jun 18, 2020
@zube zube bot unassigned jsoriano Jun 18, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 18, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19268 updated]

  • Start Time: 2020-06-23T18:47:46.923+0000

  • Duration: 61 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 6504
Skipped 1230
Total 7734

@zube zube bot removed the [zube]: Inbox label Jun 18, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations-platforms (Team:Platforms)

@blakerouse blakerouse mentioned this pull request Jun 24, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in progress Pull request is currently in progress. Team:Platforms Label for the Integrations - Platforms team v7.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metricbeat : Cloudfoundry input dropping healthwatch metrics

4 participants