Skip to content

Cherry-pick #18352 to 7.x: Add new mode to multiline reader to aggregate constant number of lines#19243

Merged
kvch merged 2 commits intoelastic:7.xfrom
kvch:backport_18352_7.x
Jun 17, 2020
Merged

Cherry-pick #18352 to 7.x: Add new mode to multiline reader to aggregate constant number of lines#19243
kvch merged 2 commits intoelastic:7.xfrom
kvch:backport_18352_7.x

Conversation

@kvch
Copy link
Copy Markdown
Contributor

@kvch kvch commented Jun 17, 2020

Cherry-pick of PR #18352 to 7.x branch. Original message:

What does this PR do?

This PR adds a new mode for the multiline reader of Libbeat (exposed in Filebeat). The new mode lets users to aggregate the configured number of lines into a single event.

Example configuration to aggregate 5 lines:

muliline.type: count
multiline.count_lines: 5

This PR also adds a new configuration option skip_newline. If set, Filebeat does not add a newline when two events are concatenated.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #18038

elastic#18352)

## What does this PR do?

This PR adds a new mode for the multiline reader of Libbeat (exposed in Filebeat). The new mode lets users to aggregate the configured number of lines into a single event.

Example configuration to aggregate 5 lines:
```yaml
muliline.type: count
multiline.count_lines: 5
```

This PR also adds a new configuration option `skip_newline`. If set, Filebeat does not add a newline when two events are concatenated.

Closes elastic#18038
(cherry picked from commit e3f51ab)
@kvch kvch added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Jun 17, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 17, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 17, 2020
Copy link
Copy Markdown

@urso urso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please cleanup changelog before merging.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 17, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19243 updated]

  • Start Time: 2020-06-17T10:58:41.397+0000

  • Duration: 80 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 6778
Skipped 1069
Total 7847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team [zube]: Done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants