Cherry-pick #18979 to 7.x: Fix metrics hints builder to avoid wrong container metadata usage when port is not exposed#19233
Merged
jsoriano merged 1 commit intoelastic:7.xfrom Jun 18, 2020
Conversation
…n port is not exposed (elastic#18979) (cherry picked from commit 2f7b501)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
ChrsMark
approved these changes
Jun 17, 2020
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Member
Author
|
jenkins, run the tests please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18979 to 7.x branch. Original message:
Type of PR
What does this PR do?
I have enhanced the emitEvent to generate a pod level event with no port. The hints builder checks to see if there is a port or not. If not then it uses the pod level metadata to monitor
data.host:<port>annotations. This ensures that we dont use the wrong container metadata to start up a metricbeat module or do it multiple times as well.Why is it important?
The way that things exist today is that when ports arent exposed, the container meta is non-deterministic
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Fixes: #12011
Co-Authored-By: Vijay Samuel vjsamuel@ebay.com