Skip to content

Cherry-pick #19114 to 7.x: Rename to management.Manager, add UpdateStatus to Manager interface.#19172

Merged
blakerouse merged 1 commit intoelastic:7.xfrom
blakerouse:backport_19114_7.x
Jun 12, 2020
Merged

Cherry-pick #19114 to 7.x: Rename to management.Manager, add UpdateStatus to Manager interface.#19172
blakerouse merged 1 commit intoelastic:7.xfrom
blakerouse:backport_19114_7.x

Conversation

@blakerouse
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse commented Jun 12, 2020

Cherry-pick of PR #19114 to 7.x branch. Original message:

What does this PR do?

Renames management.ConfigManager to management.Manager being that it now does more than just manage configurations. Adds UpdateStatus to management.Manager to allow a beat to update the status.

Using FleetManager the status will be propagated over the elastic-agent-client to the controlling agent.

Why is it important?

So status can be reported both to the controlling Agent and up to Fleet for observability of the beats that Agent is running.

Reporting a Failed status to Agent will result in the Agent stopping and restarting the beat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@blakerouse
Rename to management.Manager, add UpdateStatus to Manager interface. (e…
649baeb 
…lastic#19114)

* Rename management.ConfigManager to management.Manager, add UpdateStatus to Manager interface.

* Update docstring for Failed status.

* Add to developer changelog.

* Add StatusReporter interface, wrap client.Status in lock. Add tests for statusToProtoStatus.

(cherry picked from commit 05c9065)
@blakerouse blakerouse requested a review from a team as a code owner June 12, 2020 17:23
@blakerouse blakerouse added [zube]: In Review backport Team:Ingest Management Team:Services (Deprecated) Label for the former Integrations-Services team labels Jun 12, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 12, 2020

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 12, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 12, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19172 opened]

  • Start Time: 2020-06-12T17:24:24.964+0000

  • Duration: 80 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 6691
Skipped 1069
Total 7760

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-12T18:41:33.837+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-12T18:05:36.408+0000

    • log

ph
ph approved these changes Jun 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, backport looks fine.

@blakerouse blakerouse merged commit ec7d942 into elastic:7.x Jun 12, 2020
@blakerouse blakerouse deleted the backport_19114_7.x branch June 12, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ph ph ph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team [zube]: In Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blakerouse @elasticmachine @ph