Skip to content

Cherry-pick #18685 to 7.x: Download snapshot artifacts from snapshots repo#19155

Merged
michalpristas merged 1 commit intoelastic:7.xfrom
michalpristas:backport_18685_7.x
Jun 12, 2020
Merged

Cherry-pick #18685 to 7.x: Download snapshot artifacts from snapshots repo#19155
michalpristas merged 1 commit intoelastic:7.xfrom
michalpristas:backport_18685_7.x

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Jun 12, 2020

Cherry-pick of PR #18685 to 7.x branch. Original message:

What does this PR do?

This PR introduces new downloader which tries to detect snapshot artifact repository in case agent is built as a snapshot.
If detection fails it just does not include snapshot downloader and proceed as usual (with disk backed up by configured downloader)

Why is it important?

More intuitive scenario when you build a snapshot without anything else and it downloads dependencies. Without this it would fail trying to download SNAPSHOT of 8.0.0 from official elastic.co

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

cc @111andre111

@michalpristas
[Ingest Manager] Download snapshot artifacts from snapshots repo (ela…
baaa581 
…stic#18685)

[Ingest Manager] Download snapshot artifacts from snapshots repo (elastic#18685)
@michalpristas michalpristas self-assigned this Jun 12, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 12, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 12, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 12, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19155 opened]

  • Start Time: 2020-06-12T10:40:53.245+0000

  • Duration: 32 min 11 sec

Steps errors

Expand to view the steps failures

  • Name: Install Go 1.13.10

    • Description: .ci/scripts/install-go.sh

    • Duration: 1 min 22 sec

    • Start Time: 2020-06-12T11:03:43.391+0000

    • log

blakerouse
blakerouse approved these changes Jun 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit a3b8a4a into elastic:7.x Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels

backport enhancement Ingest Management:beta1 Group issues for ingest management beta1 review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalpristas @elasticmachine @blakerouse