Skip to content

Cherry-pick #18892 to 7.x: [Filebeat] Adds oauth2 support for httpjson input#19122

Merged
marc-gr merged 1 commit intoelastic:7.xfrom
marc-gr:backport_18892_7.x
Jun 16, 2020
Merged

Cherry-pick #18892 to 7.x: [Filebeat] Adds oauth2 support for httpjson input#19122
marc-gr merged 1 commit intoelastic:7.xfrom
marc-gr:backport_18892_7.x

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Jun 11, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #18892 to 7.x branch. Original message:

What does this PR do?

Adds oauth2 support to filebeat HTTPJSON input.

Why is it important?

This will let us pull data from oauth2 authenticated sources, like AzureAD or GSuite.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #18415

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 11, 2020

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 11, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 11, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19122 updated]

  • Start Time: 2020-06-16T10:13:40.954+0000

  • Duration: 75 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 6778
Skipped 1069
Total 7847

@marc-gr marc-gr force-pushed the backport_18892_7.x branch from 828f575 to 176a6cb Compare June 11, 2020 08:06
@marc-gr marc-gr requested a review from a team June 15, 2020 10:06
@marc-gr
[Filebeat][httpjson] Adds oauth2 support for httpjson input (elastic#…
fce075e 
…18892)

* Filebeat HTTPJSON input initial changes to support oauth2 client_credentials

* [Filebeat][httpjson] Add EndpointParams option to oauth config

* Add provider specific settings to oauth httpjson

* Change config as suggested and add config tests

* Add checks for invalid json in google validation

* Add documentation and azure.resource

* Add oauth2 test and update changelog

* Address docs and change new test case into table tests

* Check if oauth2 is enabled in config.Validate and add test

Closes elastic#18415

(cherry picked from commit b6cd17c)
@marc-gr marc-gr force-pushed the backport_18892_7.x branch from 176a6cb to fce075e Compare June 16, 2020 10:12
@marc-gr marc-gr merged commit 49d511d into elastic:7.x Jun 16, 2020
@marc-gr marc-gr deleted the backport_18892_7.x branch June 16, 2020 11:35
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adriansr adriansr adriansr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-gr @elasticmachine @adriansr